[NFC] Remove redundant DependencyResolver protocol
#7127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This protocol doesn't define any requirements and was used for nemaspacing a single tuple typealias. Instead of typealiasing this fairly complex and pervasively used tuple, we should define a separate struct for it. Then the protocol itself can be removed as completely unused. Also used this as an opportunity to clean up file naming and directory layout in the `PackageGraph` module.
|
@swift-ci test |
MaxDesiatov
added
the
no functional change
tomerd
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This protocol doesn't define any requirements and was used for nemaspacing a single tuple typealias. Instead of typealiasing this fairly complex and pervasively used tuple, we should define a separate struct for it. Then the protocol itself can be removed as completely unused.
Modifications:
Defined new
struct DependencyResolverBindingwith cleanly named fields, which now avoids tautological expressions that look likebinding.bindingand also avoids re-declaration of this tuple type explicitly in multiple places.One other
typealiasinprotocol DependencyResolveris unused, thus the whole protocol is unused and now can be removed.Also used this as an opportunity to clean up file naming and directory layout in the
PackageGraphmodule.Result:
This confusing protocol is removed from the codebase. Readability is improved with explicit struct field names instead of ad-hoc tuple use. Directory layout makes it more obvious the purpose of specific files for potential new contributors and for existing contributors when reviewing code retrospectively.