Skip to content

Revert "Avoid using temp_await in SwiftTestTool.swift" #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

Revert "Avoid using temp_await in SwiftTestTool.swift" #7196

merged 1 commit into from
Dec 13, 2023

Conversation

MaxDesiatov
Copy link
Contributor

Reverts #7016 to fix macOS CI regression:

duplicate symbol '_async_MainTu' in:
    /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/swift_package.build/Entrypoint.swift.o
    /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/swift_test.build/Entrypoint.swift.o
duplicate symbol '_async_Main' in:
    /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/swift_package.build/Entrypoint.swift.o
    /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/swift_test.build/Entrypoint.swift.o
ld: 2 duplicate symbols for architecture x86_64

This error was fixed in Swift 5.10, which is not available on CI yet.

@MaxDesiatov MaxDesiatov self-assigned this Dec 13, 2023
@MaxDesiatov
Copy link
Contributor Author

cc @AndrewHoos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov mentioned this pull request Dec 13, 2023
Closed
@MaxDesiatov MaxDesiatov enabled auto-merge (squash) December 13, 2023 10:55
@MaxDesiatov MaxDesiatov mentioned this pull request Dec 13, 2023
Merged
@MaxDesiatov MaxDesiatov requested a review from compnerd December 13, 2023 16:13
@MaxDesiatov MaxDesiatov mentioned this pull request Dec 13, 2023
Merged
@MaxDesiatov MaxDesiatov merged commit a3b9e55 into main Dec 13, 2023
@MaxDesiatov MaxDesiatov deleted the revert-7016-maxd/async-swift-test branch December 13, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@neonichu neonichu Awaiting requested review from neonichu

@tomerd tomerd Awaiting requested review from tomerd

@AndrewHoos AndrewHoos Awaiting requested review from AndrewHoos

Assignees

@MaxDesiatov MaxDesiatov

Labels
bug concurrency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @compnerd