Move the SourceKitLSPAPI target to the SwiftPM product
#7209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traditionally, we have tried to keep swift-driver and llbuild dependencies out of the `libSwiftPMDataModel` product, in fact that is the main motivation for its existence. `SourceKitLSPAPI` depends on the build parts of SwiftPM, so it should not be part of the data model library.
|
@swift-ci please test |
|
Thanks for making this change, @neonichu! |
|
@swift-ci please test |
tomerd
approved these changes
Dec 19, 2023
MaxDesiatov
approved these changes
Dec 20, 2023
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traditionally, we have tried to keep swift-driver and llbuild dependencies out of the
libSwiftPMDataModelproduct, in fact that is the main motivation for its existence.SourceKitLSPAPIdepends on the build parts of SwiftPM, so it should not be part of the data model library.