Use topologicalSort with Identifiable on ResolvedTarget
#7211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix fixes a serious performance regression introduced for deep target dependency graphs in #7160. After converting `ResolvedTarget` to a value type, its synthesized `Hashable` conformance traversed the whole dependency tree multiple times when using `topologicalSort`. This made package resolution seemingly hang for packages that had a lot of nested target graphs. We already have an implementation of `topologicalSort` on `Identifiable`, thus we should use that instead. I've also added a performance test for this in `PackageGraphPerfTests` to prevent future regressions in this area.
MaxDesiatov
added
bug
performance
|
@swift-ci test |
MaxDesiatov
commented
Dec 20, 2023
| import PackageGraph | ||
| import PackageModel | ||
|
|
||
| extension ResolvedTarget { |
There was a problem hiding this comment.
Moved from ResolvedTargetTests for reuse in perf tests.
neonichu
approved these changes
Dec 20, 2023
tomerd
approved these changes
Dec 20, 2023
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A serious performance regression was introduced for deep target dependency graphs in #7160. After converting
ResolvedTargetto a value type, its synthesizedHashableconformance traversed the whole dependency tree multiple times when usingtopologicalSort. This made package resolution seemingly hang for packages that had a lot of nested target graphs.Modifications:
We already have an implementation of
topologicalSortonIdentifiable, so we're using that now instead. I've also added a performance test for this inPackageGraphPerfTeststo prevent future regressions in this area.Result:
Resolved rdar://119807385.