[NFC] Fix some of the new Swift main snapshots warnings
#7214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `@retroactive` attribute conditionally when built with Swift 5.10. Also fixed a few other warnings that were introduced recently with an unused `let` binding and an unused `Comparable` conformance.
MaxDesiatov
added
the
no functional change
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
main warnings
MaxDesiatov
changed the title
main warningsmain snapshots warnings
neonichu
reviewed
Dec 21, 2023
neonichu
reviewed
Dec 21, 2023
|
@swift-ci test |
|
@swift-ci test windows |
neonichu
approved these changes
Dec 21, 2023
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift snapshots off
mainwarn about@retroactiveattribute not present on retroactively added protocol conformance, i.e. when a type and a protocol it conforms to are coming from different modules.Modifications:
Added
@retroactiveattribute conditionally when built with Swift versions lower than 5.10. Also fixed a few other warnings that were introduced recently with an unusedletbinding and an unusedComparableconformance.Result:
Reduced number of warnings when building with Swift
mainsnapshots. New concurrency warnings appearing in Swiftmainare untouched here, as they require much more invasive changes to fixSendableconformances.