[Traits] Integrate traits into module loading #7689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci please test |
# Motivation In my previous PR I landed the APIs for package traits. We now have to take this information into consideration when evaluating the module graph. # Modification This PR implements the various trait features in the module graph loading stage. Including resolving optional dependencies, enabled traits of dependencies, build settings based on traits and passing defines for traits. This PR also contains an exhaustive test fixtures which we can use to check if all trait functionality is working as expected.
FranzBusch
force-pushed
the
fb-moduels-and-loading
branch
from
4451034 to
5e4c28b
Compare
|
@swift-ci please test |
FranzBusch
force-pushed
the
fb-moduels-and-loading
branch
from
5e4c28b to
28ca7a4
Compare
|
@swift-ci please test |
MaxDesiatov
reviewed
Jun 20, 2024
MaxDesiatov
reviewed
Jun 20, 2024
Sources/PackageModel/Manifest/PackageDependencyDescription.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Jun 20, 2024
Sources/PackageModel/Manifest/PackageDependencyDescription.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Jun 20, 2024
MaxDesiatov
reviewed
Jun 20, 2024
MaxDesiatov
reviewed
Jun 20, 2024
MaxDesiatov
reviewed
Jun 20, 2024
Sources/PackageModel/Manifest/PackageDependencyDescription.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Jun 20, 2024
Sources/PackageModel/Manifest/PackageDependencyDescription.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Jun 20, 2024
|
@swift-ci please test |
|
@swift-ci test windows |
FranzBusch
force-pushed
the
fb-moduels-and-loading
branch
from
305afc8 to
25f57e1
Compare
|
@swift-ci please test |
|
@swift-ci test windows |
MaxDesiatov
approved these changes
Jun 20, 2024
|
@swift-ci test windows |
|
@swift-ci please test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
MaxDesiatov
added
pending evolution proposal
enhancement
package manifests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In my previous PR I landed the APIs for package traits. We now have to take this information into consideration when evaluating the module graph.
Modification
This PR implements the various trait features in the module graph loading stage. Including resolving optional dependencies, enabled traits of dependencies, build settings based on traits and passing defines for traits.
This PR also contains an exhaustive test fixtures which we can use to check if all trait functionality is working as expected.