[6.0][PackageDescription] SE-0441: Rename swiftLanguageVersion to `swift…#7813
Merged
bnbarham merged 2 commits intoJul 24, 2024
Merged
Conversation
…LanguageMode` - Deprecates `swiftLanguageVersion` API to maintain source compatibility with existing manifests; - Introduces new PackageDescription API - `swiftLanguageMode` (available from PackageDescription 6 on); - Renames multiple internal APIs to use `mode` instead of `version` when appropriate; - Build setting is still `-swift-version` but would be changed to use `mode` when it becomes available.
Contributor
Author
|
@swift-ci please test |
…sions:` initializer Allow `swiftLanguageVersions:` if it's explicitly specified to maintain source compatibility with existing manifests.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows platform |
bnbarham
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…LanguageMode`
Explanation:
Implementation of SE-0441.
swiftLanguageVersionAPI to maintain source compatibility with existing manifests;swiftLanguageMode(available from PackageDescription 6 on);modeinstead ofversionwhen appropriate;-swift-versionbut would be changed to usemodewhen it becomes available.Main Branch PR: Adopt language mode naming in
PackageDescriptionAPI #7620Risk: Low (Diagnoses invalid code instead of crashing and allows more uses of init accessors in accordance with the proposal).
Reviewed By: @MaxDesiatov @xedin @bnbarham
Testing: Existing test-cases were modified and new tests were added.
(cherry picked from commit 844156b1e5f2d219541f7487f0d6e3d33890f139)