Get run and test working against Swift Build. #8331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschaefer2
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
Cleans up handling of the new build system. It's close to the old xcode build system but with a couple of differences. Gets rid of the boolean isXcodeBuild and pass in the actual Kind so we can do different things based on which one is selected. Selects the build output path for binaries based on the selection. Also cleans up code with a missing wait for the build service to complete and with with the file descriptor close before swift run execs the process.
dschaefer2
force-pushed
the
swbuild-run-test
branch
from
a2fb6ee to
b70702d
Compare
jakepetroules
approved these changes
Mar 6, 2025
Swift Build adds -windows and -linux for these. I'll raise a GH issue to query the build system for this value.
Remember kids, build before commit...
owenv
requested changes
Mar 11, 2025
owenv
approved these changes
Mar 11, 2025
|
@swift-ci please test |
|
@swift-ci please test windows |
| if isXcodeBuildSystemEnabled { | ||
| return dataPath.appending(components: "Products", configuration.dirname.capitalized) | ||
| } else { | ||
| // TODO: query the build system for this. |
There was a problem hiding this comment.
I filed swiftlang/swift-build#286 to track the API needed for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up handling of the new build system. It's close to the old xcode build system but with a couple of differences. Gets rid of the boolean isXcodeBuild and pass in the actual Kind so we can do different things based on which one is selected. Selects the build output path for binaries based on the selection.
Also cleans up code with a missing wait for the build service to complete and with with the file descriptor close before swift run execs the process.