-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Include Swift Build support in second stage bootstrap builds #8334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -518,6 +518,11 @@ def install_swiftpm(prefix, args): | |
dest = os.path.join(prefix, "lib", "swift", "pm", "PluginAPI") | ||
install_dylib(args, "PackagePlugin", dest, ["PackagePlugin"]) | ||
|
||
# Install resource bundles produced during the build. | ||
for file in os.listdir(args.bin_dir): | ||
if file.endswith('.bundle') or file.endswith('.resources'): | ||
install_binary(args, file, os.path.join(os.path.join(prefix, "share"), "pm")) | ||
|
||
|
||
# Helper function that installs a dynamic library and a set of modules to a particular directory. | ||
def install_dylib(args, library_name, install_dir, module_names): | ||
|
@@ -809,7 +814,6 @@ def get_swiftpm_env_cmd(args): | |
|
||
if args.llbuild_link_framework: | ||
env_cmd.append("SWIFTPM_LLBUILD_FWK=1") | ||
env_cmd.append("SWIFTPM_NO_SWBUILD_DEPENDENCY=1") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thought: I wonder if the smoke test builds will pass with the dependency. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was able to get an earlier run passing, the latest test run just has minor tweaks so I think it'll work |
||
env_cmd.append("SWIFTCI_USE_LOCAL_DEPS=1") | ||
env_cmd.append("SWIFTPM_MACOS_DEPLOYMENT_TARGET=%s" % g_macos_deployment_target) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Should this be added to the command-line options in
swift-bootstrap/main.swift
too so that we can bootstrap building SwiftPM itself with the swiftbuild system someday?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swift Build still has a fallback to the resources directory in the build directory, which I think will cover this case