Fix call to SWBBuildService.createSession #8357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlang/swift-build#266 changed the API of SwiftBuildService.createSession.
plemarquand
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
owenv and
bkhouri
as code owners
|
@swift-ci please test |
owenv
reviewed
Mar 11, 2025
| switch await service.createSession(name: name, resourceSearchPaths: packageManagerResourcesDirectory.map { [$0.pathString] } ?? [], cachePath: nil, inferiorProductsPath: nil, environment: nil) { | ||
| switch await service.createSession( | ||
| name: name, | ||
| developerPath: nil, |
There was a problem hiding this comment.
developerPath defaults to nil, so it shouldn't be needed here. Were you seeing the build fail in some configuration?
There was a problem hiding this comment.
I think my dependencies got in to a bad state, I switched to a known good toolchain, cleaned and rebuilt and its not an issue.
There was a problem hiding this comment.
Same here. Need to remember to swift package update regularly to get the latest swift build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftlang/swift-build#266 changed the API of SwiftBuildService.createSession.