Add missing self in SwiftBuildSystem
#8368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlang#8366 is a revert, but it reverted back to a point before there was an outer `withService` block wrapping the code. As a result a `self` was missing on `buildParameters`, causing a build failure.
plemarquand
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
owenv and
bkhouri
as code owners
|
@swift-ci test |
dschaefer2
approved these changes
Mar 13, 2025
jakepetroules
approved these changes
Mar 13, 2025
|
swiftlang/swift-build#300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8366 is a revert, but it reverted back to a point before there was an outer
withServiceblock wrapping the code. As a result aselfis missing onbuildParameters, causing a build failure.