Minor Codable conformance improvements in SwiftBuildSupport #8449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattos
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
Apr 3, 2025
pmattos
commented
Apr 3, 2025
| try super.init(from: decoder) | ||
| } | ||
| } | ||
|
|
||
| /// Abstract base class for all items in the group hierarchy. | ||
| public class Reference: TypedObject { | ||
| public class Reference: HighLevelObject { |
There was a problem hiding this comment.
Not really a high-level object... but will go away in my next PR.
| @@ -693,7 +712,7 @@ public enum PIF { | |||
| } | |||
|
|
|||
| /// Abstract base class for all build phases in a target. | |||
| public class BuildPhase: TypedObject { | |||
| public class BuildPhase: HighLevelObject { | |||
There was a problem hiding this comment.
Not really a high-level object... but will go away in my next PR.
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test windows self hosted |
dschaefer2
approved these changes
Apr 4, 2025
|
@swift-ci please test self hosted windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some of the
SwiftBuildSupport/PIFBuilder.swiftencoding/decoding code was using unsafe string keys. This replaces with proper typesafe keys.This part of the ground work to support the new PIF builder in
SwiftBuildSupport(i.e., rdar://147527170).Modifications:
When conforming to
Codable, replace string keys withenumbased keys instead.Result:
The resulting code is safer and easier to understand.
Tracked by rdar://148546582.