Tests: Enable more WorkspaceTests on Windows #8457
Conversation
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
bkhouri
force-pushed
the
t/main/enable_workspace_tests_on_windows_gh8433_rdar148248105
branch
from
625718d to
1cb7705
Compare
|
@swift-ci please test |
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
bkhouri
added
windows
test suite
|
After speaking with @MaxDesiatov offline, I will try to undo the changes to the sandbox root path change. |
To clarify, root path changes make sense to me, especially if they fix the tests. It's the separator changes that I'm not sure are required (or needed). Also, if there's a way to remove the whitespace changes that would be great too. |
@MaxDesiatov Are you referring to the separator changes as follows? If so, those are required. if not, can you please provide an example? |
bkhouri
force-pushed
the
t/main/enable_workspace_tests_on_windows_gh8433_rdar148248105
branch
2 times, most recently
from
0869c3c to
167144e
Compare
|
@swift-ci please test |
|
@swift-ci test self hosted windows |
bkhouri
force-pushed
the
t/main/enable_workspace_tests_on_windows_gh8433_rdar148248105
branch
from
167144e to
e9ea09a
Compare
|
@swift-ci test |
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/enable_workspace_tests_on_windows_gh8433_rdar148248105
branch
2 times, most recently
from
fbfaf2d to
7a5e62e
Compare
|
@swift-ci test |
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
Many WorkspaceTests instantiate a MockWorkspace, which takes a path as an input. The tests were defining a POSIX-like path as the sandbox directory, however, some assertions were incorrect as, on these *nix like filesystem, the canonical path name and the path were identical. Update the WorkspaceTests expectation accordingly, and add some automated tests to cover the InMemoryFileSystem.
…g on Linux Smoke test CI
bkhouri
force-pushed
the
t/main/enable_workspace_tests_on_windows_gh8433_rdar148248105
branch
from
7a5e62e to
a5ed5f5
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test linux |
|
@swift-ci test windows |
Many WorkspaceTests instantiate a MockWorkspace, which takes a path as an input. The tests were defining a POSIX-like path as the sandbox directory, however, some assertions were incorrect as, on these *nix like filesystem, the canonical path name and the path were identical.
Update the WorkspaceTests expectation accordingly, and add some automated tests to cover the InMemoryFileSystem (which is commented out as a crash occurs in the Linux Platform CI build with Swift Testing tests).
Relates: #8433
rdar://148248105