Link test command test failures on Linux to issue #8459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri and
daveyc123
as code owners
|
@swift-ci please test |
bkhouri
reviewed
Apr 8, 2025
|
@swift-ci please test |
|
@swift-ci test Windows |
|
@swift-ci test Linux |
|
@swift-ci test self hosted windows |
|
@swift-ci test smoke test Linux |
|
@swift-ci please test |
|
@swift-ci test Windows |
bkhouri
approved these changes
Apr 11, 2025
|
@swift-ci test self hosted windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestCommandTests fail on Linux due to a common linker problem with swift build build system,
which is the missing 'main' symbol problem. This is described further detail in #8439.
Provide the link in the skip messages and remove the TODO tags since the investigation is complete
and the reason for the failures is now known.
Update the common test case logic so that it dumps the command execution stdout and stderr
in the case of failure to help diagnose these result.xml failures immediately in the logs.