Skip to content

Tests: Enable tests on Windows #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Tests: Enable tests on Windows #8466

merged 1 commit into from
Apr 9, 2025

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Apr 8, 2025 •
edited
Loading

Enable additional tests on Windows host platform

  • Enable a few AsyncProcessTests
  • Enable the lone skipped test in EnvironmentTests
  • Enable the only skipped test in Tests/SourceKitLSPAPITests/SourceKitLSPAPITests.swift
  • Enable the only skipped test in Tests/BuildTests/BuildSystemDelegateTests.swift
  • Enable the lone skipped test in Tests/BuildTests/LLBuildManifestBuilderTests.swift
  • Replace usages of fixwin with AbsolutePath.pathString

Related to: #8433
rdar://148248105

@bkhouri
Tests: Enable tests on Windows
8048d4c 
- Enable a few AsyncProcessTests
- Enable the lone skipped test in EnvironmentTests
- Enable all SourceKitLSPAPITests on Windows
- Replace usages of `fixwin` with `AbsolutePath.pathString`

Related to: swiftlang#8433
rdar://148248105
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test self hosted windows

@bkhouri bkhouri added windows test suite improvements to SwiftPM test suite labels Apr 8, 2025
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test

@bkhouri bkhouri marked this pull request as ready for review April 8, 2025 20:04
@bkhouri bkhouri enabled auto-merge (squash) April 8, 2025 20:09
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 9, 2025

@swift-ci test Linux

jakepetroules
jakepetroules approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good Windows equivalent for echo and cat would be to run cmd.exe /c echo and cmd.exe /c type. Happy to get this landed now see that as part of a follow-on PR if you want.

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 9, 2025

@swift-ci test self hosted windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 9, 2025

@swift-ci test macOS

@bkhouri bkhouri merged commit cc0b1a5 into swiftlang:main Apr 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees
No one assigned
Labels
test suite improvements to SwiftPM test suite windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkhouri @jakepetroules