Skip to content

Revert "Copy helpers internally" #8474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Revert "Copy helpers internally" #8474

merged 1 commit into from
Apr 9, 2025

Conversation

nate-chandler
Copy link
Contributor

Reverts #8467

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@dschaefer2
Copy link
Member

@swift-ci please test self hosted windows

@dschaefer2 dschaefer2 enabled auto-merge (squash) April 9, 2025 22:04
@bnbarham bnbarham disabled auto-merge April 9, 2025 22:27
@bnbarham bnbarham merged commit cd5d9dd into main Apr 9, 2025
2 of 6 checks passed
@bnbarham bnbarham deleted the revert-8467-t/main/add_swift_testing_helpers branch April 9, 2025 22:27
@drodriguez
Copy link
Contributor

Is there some information about the why the revert? Was because it was using Testing? I also got a strange compiler crash While evaluating request TypeCheckFunctionBodyRequest(_InternalTestSupport.(file).Trait extension.requireHostOS(_:when:)@…/Sources/_InternalTestSupport/SkippedTestSupport.swift:18:24) but I am not sure if that's my fault.
Thanks!

@bkhouri
Copy link
Contributor

bkhouri commented Apr 10, 2025 •
edited
Loading

Is there some information about the why the revert? Was because it was using Testing? I also got a strange compiler crash While evaluating request TypeCheckFunctionBodyRequest(_InternalTestSupport.(file).Trait extension.requireHostOS(_:when:)@…/Sources/_InternalTestSupport/SkippedTestSupport.swift:18:24) but I am not sure if that's my fault. Thanks!

@drodriguez I suspect this was reverted as it broke the CI PR builds for the https://github.com/swiftlang/swift project since the builds did not install Swift Testing.

I posted swiftlang/swift#80717 and #8476 to see if the two PR will fix the issues.

@bkhouri bkhouri mentioned this pull request Apr 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschaefer2 dschaefer2 dschaefer2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nate-chandler @dschaefer2 @drodriguez @bkhouri @bnbarham