Skip to content

Add swift test --attachments-path. #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Apr 11, 2025

This PR adds support for the --attachments-path CLI argument on swift test as approved in ST-0009. We will maintain support for the older --experimental-attachments-path version through Swift 6.2.

The implementation of this option is held entirely in Swift Testing at this time, so no actual code is needed to support it, we just need to make sure Swift Argument Parser doesn't complain about it.

Resolves rdar://147753584.

@plemarquand has integration tests but they're blocked on a newer toolchain; unit testing of this argument exists in the Swift Testing repo.

This PR adds support for the `--attachments-path` CLI argument on `swift test` as approved in [ST-0009](https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0009-attachments.md). We will maintain support for the older `--experimental-attachments-path` version through Swift 6.2.

The implementation of this option is held entirely in Swift Testing at this time, so no actual code is needed to support it, we just need to make sure Swift Argument Parser doesn't complain about it.
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

See also swiftlang/swift-testing#1074

@grynspan
Copy link
Contributor Author

@younata FYI.

@grynspan grynspan requested a review from plemarquand April 11, 2025 19:28
@bkhouri
Copy link
Contributor

bkhouri commented Apr 11, 2025

@swift-ci test self hosted windows

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test self hosted windows

@grynspan grynspan enabled auto-merge (squash) April 14, 2025 17:47
@plemarquand
Copy link
Contributor

@swift-ci test macOS

@plemarquand
Copy link
Contributor

@swift-ci test macOS

1 similar comment
@plemarquand
Copy link
Contributor

@swift-ci test macOS

@plemarquand
Copy link
Contributor

@swift-ci test windows

@bkhouri
Copy link
Contributor

bkhouri commented Apr 16, 2025

@swift-ci test self hosted windows

@grynspan grynspan merged commit 861a871 into main Apr 16, 2025
7 checks passed
@grynspan grynspan deleted the jgrynspan/attachments-path-arg branch April 16, 2025 20:05
johnbute pushed a commit to johnbute/fork-swift-package-manager that referenced this pull request Apr 17, 2025
This PR adds support for the `--attachments-path` CLI argument on `swift
test` as approved in
[ST-0009](https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0009-attachments.md).
We will maintain support for the older `--experimental-attachments-path`
version through Swift 6.2.

The implementation of this option is held entirely in Swift Testing at
this time, so no actual code is needed to support it, we just need to
make sure Swift Argument Parser doesn't complain about it.

Resolves rdar://147753584.

@plemarquand has integration tests but they're blocked on a newer
toolchain; unit testing of this argument exists in the Swift Testing
repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command-line interface swift test Changes impacting `swift test` tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants