Copy helpers internally - take 3 #8495
Draft
+113
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test windows |
|
@swift-ci test macOS |
|
@swift-ci test self hosted windows |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 15, 2025
Enable all but 3 tests. Some AsyncProcessTests call to `cat` and `echo` commands. Update the executable to be called correctly on Windows via the `cmd.exe /c` command, where the `cat` equivalent is `type`, which displays the file contents. Also, many tests call a script. We created a batch file, which simply calls the associated script invoked by python. Only 3 tests remain skipped. - one failed assertion on Windows - two otheers appear to have caused `swift test` tp hang. Depends on: swiftlang#8495 Related to: swiftlang#8433 rdar://148248105
bkhouri
force-pushed
the
t/main/copy_helpers_2
branch
from
1cc14bd to
3e145e2
Compare
|
@swift-ci test |
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 15, 2025
Enable all but 3 tests. Some AsyncProcessTests call to `cat` and `echo` commands. Update the executable to be called correctly on Windows via the `cmd.exe /c` command, where the `cat` equivalent is `type`, which displays the file contents. Also, many tests call a script. We created a batch file, which simply calls the associated script invoked by python. Only 3 tests remain skipped. - one failed assertion on Windows - two otheers appear to have caused `swift test` tp hang. Depends on: swiftlang#8495 Related to: swiftlang#8433 rdar://148248105
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/copy_helpers_2
branch
from
3e145e2 to
ce35984
Compare
|
@swift-ci test |
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: swiftlang#8433 rdar://148248105
bkhouri
force-pushed
the
t/main/copy_helpers_2
branch
from
ce35984 to
c0f4f8e
Compare
|
@swift-ci test self hosted windows |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 16, 2025
Enable all but 3 tests. Some AsyncProcessTests call to `cat` and `echo` commands. Update the executable to be called correctly on Windows via the `cmd.exe /c` command, where the `cat` equivalent is `type`, which displays the file contents. Also, many tests call a script. We created a batch file, which simply calls the associated script invoked by python. Only 3 tests remain skipped. - one failed assertion on Windows - two otheers appear to have caused `swift test` tp hang. Depends on: swiftlang#8495 Related to: swiftlang#8433 rdar://148248105
|
@swift-ci test windows |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 22, 2025
Enable all but 3 tests. Some AsyncProcessTests call to `cat` and `echo` commands. Update the executable to be called correctly on Windows via the `cmd.exe /c` command, where the `cat` equivalent is `type`, which displays the file contents. Also, many tests call a script. We created a batch file, which simply calls the associated script invoked by python. Only 3 tests remain skipped. - one failed assertion on Windows - two otheers appear to have caused `swift test` tp hang. Depends on: swiftlang#8495 Related to: swiftlang#8433 rdar://148248105
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 22, 2025
Enable all but 3 tests. Some AsyncProcessTests call to `cat` and `echo` commands. Update the executable to be called correctly on Windows via the `cmd.exe /c` command, where the `cat` equivalent is `type`, which displays the file contents. Also, many tests call a script. We created a batch file, which simply calls the associated script invoked by python. Only 3 tests remain skipped. - one failed assertion on Windows - two otheers appear to have caused `swift test` tp hang. Depends on: swiftlang#8495 Related to: swiftlang#8433 rdar://148248105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until #8223 is fixed copy some helpers from
IntergrationTests/Source/IntegrationTeststoTest/_InternalTestSupportso we can re-use the functionality.Related to: #8433
rdar://148248105
Requires: swiftlang/swift#80717