Really fix duplicate module maps this time. #8498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had mucked with the fix to finish some testing and forgot to put the fix back. And the test didn't properly catch that. Fixing both.
dschaefer2
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
1 task
|
@swift-ci please test macos |
|
@swift-ci please self hosted test macOS |
|
@swift-ci please test macOS |
bripeticca
approved these changes
Apr 16, 2025
dschaefer2
added a commit
that referenced
this pull request
Apr 17, 2025
This reverts commit 6245fa9.
bnbarham
pushed a commit
that referenced
this pull request
Apr 17, 2025
Reverts #8498 Broke swift-foundation build.
johnbute
pushed a commit
to johnbute/fork-swift-package-manager
that referenced
this pull request
Apr 17, 2025
I had mucked with the fix to finish some testing and forgot to put the fix back. And the test didn't properly catch that. Fixing both.
johnbute
pushed a commit
to johnbute/fork-swift-package-manager
that referenced
this pull request
Apr 17, 2025
Reverts swiftlang#8498 Broke swift-foundation build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had mucked with the fix to finish some testing and forgot to put the fix back. And the test didn't properly catch that. Fixing both.