Tests: Ensure we get clean test fixtures #8507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattos
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
pmattos
commented
Apr 15, 2025
|
|
||
| // Ensure we get a clean test fixture. | ||
| try localFileSystem.removeFileTree(dstDir.appending(component: ".build")) | ||
| try localFileSystem.removeFileTree(dstDir.appending(component: ".swiftpm")) | ||
| } |
There was a problem hiding this comment.
This is the fix... the rest is just code formatting.
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test self hosted windows |
plemarquand
approved these changes
Apr 16, 2025
jakepetroules
approved these changes
Apr 16, 2025
johnbute
pushed a commit
to johnbute/fork-swift-package-manager
that referenced
this pull request
Apr 17, 2025
### Motivation: When running tests ensure the *test fixtures* we copy over to temporary directories don't carry over any previous build information. ### Modifications: When copying packages from `/Fixtures/**` we now ensure we delete any `.build` or `.swiftpm` directories, if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When running tests ensure the test fixtures we copy over to temporary directories don't carry over any previous build information.
Modifications:
When copying packages from
/Fixtures/**we now ensure we delete any.buildor.swiftpmdirectories, if any.Result:
Safer tests hopefully :-)
PS. This was driving me nuts as I was playing around with a given
/Fixtures/Foobut also running tests against it! The tests behaviour would vary depending on whatswiftcommands I had previously ran in/Fixtures/Foo... fun times! 🙃