Tests: Enable some BuildTests/**/*.swift tests on Windows #8512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable the BuildPlanTests on Windows - Split a PrepareForIndexTests tests into two withthe passing, and failing on Windows - update/add a message on some skipped windows tests, with a reference to GitHub Issue Related to: swiftlang#8433 rdar://148248105
|
@swift-ci test |
|
@swift-ci test self hosted windows |
bkhouri
changed the title
| @@ -0,0 +1,33 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Could this be done in pure batch? This adds a python dependency to the tests, which might not be present on the host system.
There was a problem hiding this comment.
It can. Could you please this with "request changes" so we don't loose track of this request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #8433
rdar://148248105