[6.2][ModuleGraph] Bring back original check for implicit system libraries #8825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original check was about system libraries only, the new one checks all of the implicit modules. (cherry picked from commit 68d07f2)
xedin
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
Jun 13, 2025
dschaefer2
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #8824
Explanation:
The original check was about system libraries only, the new one filters all of the implicit modules (including snippets) which is incorrect. The is a follow-up to [6.2] Fixes a few issues with
swift package {migrate, add-setting}commands #8812Main Branch PR: [ModuleGraph] Bring back original check for implicit system libraries #8824
Risk: Low
Reviewed By: @bnbarham
Testing: No testing was added, speculative fix.
(cherry picked from commit 68d07f2)