Various fixes for tests on Windows #9268
Conversation
| basename = String(basename.dropLast(4)) | ||
| } | ||
| if basename == "/" { | ||
| if basename == "/" || basename == "\\" { |
There was a problem hiding this comment.
We should have a single central variable that is an array of the possible path separators for the host.
See https://github.com/swiftlang/swift-build/blob/bc2e7d92d36caed0399f64594b9e5518b2f83731/Sources/SWBUtil/Path.swift#L69 for example.
There might already be one in the SwiftPM codebase somewhere, or in TSC.
Also, this part of the logic should probably be constrained to file URLs.
There was a problem hiding this comment.
Ya, I couldn't find a central definition for path separators like whats in swift-build, and it looks like from this https://github.com/swiftlang/swift-package-manager/pull/6706/files we moved away from URL
There was a problem hiding this comment.
I like python's take on the separator by storing in a variable. e.g.: os.sep. Should we consider something similar for Swift?
There was a problem hiding this comment.
If by "for Swift" you mean the Swift standard library, I don't think it's appropriate for the stdlib to be aware of the concept of filesystems and file paths. Maybe a SwiftSystem API.
daveinglis
force-pushed
the
test_fixes
branch
from
8c9336b to
18543ae
Compare
daveinglis
force-pushed
the
test_fixes
branch
2 times, most recently
from
fb81f29 to
12e88df
Compare
bkhouri
left a comment
bkhouri
left a comment
There was a problem hiding this comment.
It's great to see tests being enabled for Windows!
| basename = String(basename.dropLast(4)) | ||
| } | ||
| if basename == "/" { | ||
| if basename == "/" || basename == "\\" { |
There was a problem hiding this comment.
I like python's take on the separator by storing in a variable. e.g.: os.sep. Should we consider something similar for Swift?
| } | ||
| } when: { | ||
| ProcessInfo.isHostAmazonLinux2() | ||
| ProcessInfo.isHostAmazonLinux2() //rdar://134238535 |
There was a problem hiding this comment.
suggestion: can we references a GitHub issue instead?
| await XCTAssertBuilds( | ||
| fixturePath, | ||
| Xswiftc: ["-warnings-as-errors"], | ||
| buildSystem: .native, |
There was a problem hiding this comment.
issue: this suite is verifying the native build system. can we migrate this suite to SwiftTesting and ensure we verify the SwiftBuild build system too?
This comment applies to all applicable XCTestCase
daveinglis
force-pushed
the
test_fixes
branch
3 times, most recently
from
dfe2626 to
e34946e
Compare
daveinglis
force-pushed
the
test_fixes
branch
2 times, most recently
from
8165ac5 to
9fa1a90
Compare
daveinglis
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
owenv,
plemarquand and
rconnell9
as code owners
daveinglis
force-pushed
the
test_fixes
branch
2 times, most recently
from
ec9ffa3 to
c4caddd
Compare
daveinglis
force-pushed
the
test_fixes
branch
8 times, most recently
from
167515e to
6958b5f
Compare
daveinglis
force-pushed
the
test_fixes
branch
3 times, most recently
from
e4f8614 to
13c0be3
Compare
daveinglis
force-pushed
the
test_fixes
branch
5 times, most recently
from
4e17075 to
e77d891
Compare
daveinglis
force-pushed
the
test_fixes
branch
3 times, most recently
from
d7dc932 to
33dba80
Compare
daveinglis
force-pushed
the
test_fixes
branch
from
33dba80 to
af29a59
Compare
- also mark withKnownIssues tests as isIntermittent: true so that as we fix things in dependent packages (like swift-build) we don't break swiftPM CI - serializing some test that change cwd to hopefully fix the AL2 crashes where the CWD has been deleted and calls to get CWD returns nil
daveinglis
force-pushed
the
test_fixes
branch
from
af29a59 to
87a1538
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test windows |
4 participants
Fix various tests so they pass on Windows