generator: Do not include the host toolchain by default #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
approved these changes
Jan 24, 2025
|
@swift-ci test |
euanh
force-pushed
the
default-exclude-host-toolchain
branch
from
faad2ea to
d6c27b4
Compare
👍 I've added that to the PR description. |
|
@swift-ci test |
MaxDesiatov
approved these changes
Jan 24, 2025
Not including the host toolchain matches the Swift Static Linux SDK. Users with experience of the static SDK will be familiar with the need to install a matching OSS toolchain to use it: https://www.swift.org/documentation/articles/static-linux-getting-started.html#installing-the-sdk Not including the host toolchain reduces the size of the SDK bundle by about 2GB. This makes SDKs easier to move around, wastes less storage space if multiple SDKs are installed, and speeds up the SDK build process - especially the first build, as the host toolchain does not have to be downloaded. WASM SDKs also do not include the host toolchain.
euanh
force-pushed
the
default-exclude-host-toolchain
branch
from
d6c27b4 to
7ff0b12
Compare
|
@swift-ci test |
|
Hey guy, this is awesome. I'm glad I could contribute to this! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not including the host toolchain matches the Swift Static Linux SDK. Users with experience of the static SDK will be familiar with the need to install a matching OSS toolchain to use it:
https://www.swift.org/documentation/articles/static-linux-getting-started.html#installing-the-sdk
Not including the host toolchain reduces the size of the SDK
bundle by about 2GB. This makes SDKs easier to move around,
wastes less storage space if multiple SDKs are installed, and
speeds up the SDK build process - especially the first build,
as the host toolchain does not have to be downloaded.
Wasm SDKs also do not include the host toolchain.