Skip to content

Possible compiler backward compatibility problem #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dabrahams opened this issue Mar 19, 2024 · 2 comments · Fixed by #2548
Closed

Possible compiler backward compatibility problem #2546

dabrahams opened this issue Mar 19, 2024 · 2 comments · Fixed by #2548
Labels
bug Something isn't working

Comments

@dabrahams
Copy link
Contributor

dabrahams commented Mar 19, 2024 •
edited
Loading

See ea71e1e#r139940839
@dabrahams dabrahams added the bug Something isn't working label Mar 19, 2024
@ahoppen
Copy link
Member

ahoppen commented Mar 19, 2024

Tracked in Apple’s issue tracker as rdar://124979624

ahoppen added a commit to ahoppen/swift-syntax that referenced this issue Mar 19, 2024
@ahoppen
Specify attributes inside #if before any unconditional attributes
17184f4 
Looks like the Swift 5.7 compiler errors if unconditional attributes are before attributes inside `#if`.

Fixes swiftlang#2546
rdar://124979624
@ahoppen ahoppen mentioned this issue Mar 19, 2024
Merged
@ahoppen
Copy link
Member

ahoppen commented Mar 19, 2024

Should be fixed by #2548.

ahoppen added a commit to ahoppen/swift-syntax that referenced this issue Mar 21, 2024
@ahoppen
Specify attributes inside #if before any unconditional attributes
e462d4d 
Looks like the Swift 5.7 compiler errors if unconditional attributes are before attributes inside `#if`.

Fixes swiftlang#2546
rdar://124979624
@ahoppen ahoppen mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify attributes inside #if before any unconditional attributes ahoppen/swift-syntax
2 participants
@dabrahams @ahoppen