Skip to content

Add documentation to (nearly) all public functions in the SwiftSyntax module#1670

Merged
ahoppen merged 1 commit into
swiftlang:mainfrom
ahoppen:ahoppen/write-documentation
May 24, 2023
Merged

Add documentation to (nearly) all public functions in the SwiftSyntax module#1670
ahoppen merged 1 commit into
swiftlang:mainfrom
ahoppen:ahoppen/write-documentation

Conversation

@ahoppen
Copy link
Copy Markdown
Member

@ahoppen ahoppen commented May 16, 2023

Nothing more to say, really. Let’s write some documentation. Maybe, eventually, we can enable the swift-format rule that all public declarations must have a doc comment.

@ahoppen ahoppen requested review from bnbarham and rintaro May 16, 2023 04:45
@ahoppen
Copy link
Copy Markdown
Member Author

ahoppen commented May 16, 2023

@swift-ci Please test

Copy link
Copy Markdown
Contributor

@kimdv kimdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, sorry for the ticks comments @ahoppen! 😁
I've added places where I think at would make sense to add them.

Feel free to just resolve them if you don't think they add value or sense.

Comment thread Sources/SwiftSyntax/SyntaxArena.swift Outdated
Comment thread Sources/SwiftSyntax/BumpPtrAllocator.swift Outdated
Comment thread Sources/SwiftSyntax/IncrementalParseTransition.swift Outdated
Comment thread Sources/SwiftSyntax/Syntax.swift Outdated
Comment thread Sources/SwiftSyntax/Syntax.swift Outdated
Comment thread Sources/SwiftSyntax/Syntax.swift Outdated
Comment thread Sources/SwiftSyntax/SyntaxText.swift Outdated
Comment thread Sources/SwiftSyntax/TokenSyntax.swift Outdated
Comment thread Sources/SwiftSyntax/Trivia.swift Outdated
Comment thread Sources/SwiftSyntax/Utils.swift
@ahoppen ahoppen force-pushed the ahoppen/write-documentation branch from 3270330 to 2ae353f Compare May 16, 2023 19:50
@ahoppen
Copy link
Copy Markdown
Member Author

ahoppen commented May 16, 2023

Thanks for the review @kimdv. Adding double ticks definitely makes sense.

@ahoppen
Copy link
Copy Markdown
Member Author

ahoppen commented May 16, 2023

@swift-ci Please test

@kimdv
Copy link
Copy Markdown
Contributor

kimdv commented May 16, 2023

@swift-ci please test windows

@ahoppen ahoppen merged commit 967e487 into swiftlang:main May 24, 2023
@ahoppen ahoppen deleted the ahoppen/write-documentation branch May 24, 2023 23:07
Comment thread Sources/SwiftParserDiagnostics/Utils.swift
Comment thread Sources/SwiftParserDiagnostics/Utils.swift
Comment thread Sources/SwiftParserDiagnostics/Utils.swift
Comment thread Sources/SwiftParserDiagnostics/Utils.swift
Comment thread Sources/SwiftSyntax/BumpPtrAllocator.swift
Comment thread Sources/SwiftSyntax/SyntaxText.swift
Comment thread Sources/SwiftSyntax/TokenDiagnostic.swift
Comment thread Sources/SwiftSyntax/TokenDiagnostic.swift
Comment thread Sources/SwiftSyntax/TokenSyntax.swift
Comment thread Sources/SwiftSyntax/Utils.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants