Improve diagnosis of the missing expression in a for-each loop #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTOzzi
commented
May 21, 2023
| @@ -778,7 +778,17 @@ public class ParseDiagnosticsGenerator: SyntaxAnyVisitor { | |||
| ) | |||
There was a problem hiding this comment.
I also discovered issues with the C-style for loop, but it seemed difficult to resolve them simply 🤯
(testRecovery31?, testRecovery32, testRecovery33, testRecovery38)
It appears that they should be considered as separate issues.
There was a problem hiding this comment.
Honestly, I just don’t care about the C-style for loop diagnostic. If you write C-style for loops in Swift. That diagnostic dates back in the old parser from the Swift 1 days when people were migrating from (Objective-)C to Swift and maybe didn’t know how to write Swift-style for loops and I only migrated it to the new parser as a proof-of-concept of a slightly more involved diagnostic.
kimdv
approved these changes
May 21, 2023
|
@swift-ci please test |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1602
The
expectedSequenceExpressionInForEachLoopdiagnostic message did not have FixIts.I have added an appropriate FixIt and modified the related test case 🙂