[Macros] Ability to opt-out from auto-propagation of attrs/modifiers #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DeclarationMacro` now have two optional requirements that is defaulted
to 'true':
static var propagateFreestandingMacroAttributes: Bool { get }
static var propagateFreestandingMacroModifiers: Bool { get }
My implementing these and returning 'false', macro expansion systam
won't copy attributes and/or modifiers to the expanded declarations.
rdar://110364154
|
@swift-ci Please test |
ahoppen
approved these changes
Jun 7, 2023
Comment on lines
+24
to
+25
| /// Whether to copy attributes on the expansion syntax to expanded declarations, | ||
| /// 'true' by default. |
There was a problem hiding this comment.
I think an example would illustrate the point really well here.
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeclarationMacronow have two optional requirements that is defaulted to 'true':By implementing these and returning 'false', macro expansion system won't copy attributes and/or modifiers to the expanded declarations.
rdar://110364154
I will add a test case with actual plugins in
swiftrepo.