[5.9] Make CodeBlockItemSyntax expressible by string #1740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e182ac6)
|
@swift-ci please test |
DougGregor
approved these changes
Jun 7, 2023
kimdv
approved these changes
Jun 7, 2023
|
@swift-ci please test windows |
ahoppen
approved these changes
Jun 7, 2023
|
@swift-ci please test Windows |
|
Ah that's not going to work still, CI checks out main and then runs update-checkout :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyntaxParseableconformance forCodeBlockItemSyntax. This is needed to be able to do eg.let item: CodeBlockItemSyntax = "let foo = 1"which is very useful for code block macros. While these aren't enabled in 5.9, cherry-picks will often contain tests for them (with code item macros enabled).CodeBlockItemSyntax.