[5.9] [Macros] Pass macro role for freestanding macro expansion #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DougGregor
commented
Jun 10, 2023
DougGregor
commented
- Explanation: Extend the protocol used by the macro server to include a freestanding macro role in the freestanding macro expansion request, and provide improved diagnostics when the role requested is not implemented by the macro implementation type. This is, on the whole, more informative than crashing the compiler, which is what happened before.
- Scope: Narrow; only affects validation of freestanding macro expansions.
- Risk: Low; narrow change to perform better validation when expanding freestanding macros.
- Reviewed by: @rintaro
- Issue: rdar://110418969
- Original pull request: [Macros] Pass macro role for freestanding macro expansion #1757, Eliminate redundant precondition checking #1762
Macros can only have a single freestanding macro role, so that their expansion is unambiguous. However, that restriction is at the level of a macro declaration, and is not reflected in a similar restriction on the set of macro protocols to which a macro implementation can conform. Therefore, have the compiler pass a freestanding macro role through to macro expansion in the same way that we do for attached macros, and use that to determine which macro protocol to use. Part of fixing rdar://110418969. (cherry picked from commit fe05c66)
(cherry picked from commit 4a8b665)
(cherry picked from commit a992586)
Thanks to Rintaro for pointing this out.
|
@swift-ci please test |
hborla
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.