Skip to content

remove .dynamic from library product #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

tanner0101
Copy link
Contributor

See SR-9038.

This flag prevents executable SPM projects from embedding SwiftSyntax statically.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can’t remember any particular reason why I added the dynamic type.

@ahoppen
Copy link
Member

ahoppen commented Oct 18, 2018

@swift-ci Please test

@rintaro
Copy link
Member

rintaro commented Oct 19, 2018

CC: @nkcsgexi

@nkcsgexi nkcsgexi merged commit 5d058eb into swiftlang:master Oct 19, 2018
@tanner0101
Copy link
Contributor Author

Thanks!

@tanner0101 tanner0101 deleted the patch-1 branch October 24, 2018 17:00
@loganwright
Copy link

@ahoppen would it be possible to generate a new tag that includes these changes?

@ahoppen
Copy link
Member

ahoppen commented Oct 31, 2018

CC: @nkcsgexi

@nkcsgexi
Copy link
Contributor

@loganwright do you mean a new tag for master or for a new release tag (0.40200.0)?

@kastiglione
Copy link
Contributor

+1 to a new release tag that includes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants