Remove CanImportExprSyntax and provide API to interpret an ExprSyntax as a VersionTupleSyntax #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Aug 8, 2023
Tests/SwiftParserTest/ExpressionInterpretedAsVersionTupleTests.swift
Outdated
Show resolved
Hide resolved
| extension ExprSyntax { | ||
| public func asVersionTuple(with maxComponentCount: Int) -> VersionTupleSyntax? { | ||
| var parser = Parser(self.description) | ||
| let raw = parser.parseVersionTuple(maxComponentCount: maxComponentCount) |
There was a problem hiding this comment.
You should make sure that all tokens in the ExprSyntax are represented idk the VersionTupleSyntax, similar to what we do when creating syntax nodes from string literals
And now that I think about it, I think the best thing to do, would be add a parser entry function for VersionTupleSyntax so that all that code gets auto-generated, including the following, which is necessary for memory safety
Could you add a test case for 2.0 + 1. + 1 should be unexpected nodes in that case.
There was a problem hiding this comment.
I think making this a parser entry function is a good idea! And we have to pass the maxComponentCount parameter to that function so I add a helper function below.
StevenWong12
force-pushed
the
interpret_expr_syntax_as_version_tuple_syntax
branch
from
ea1c73b to
53101dd
Compare
ahoppen
reviewed
Aug 14, 2023
StevenWong12
force-pushed
the
interpret_expr_syntax_as_version_tuple_syntax
branch
from
53101dd to
2244549
Compare
ahoppen
reviewed
Aug 21, 2023
Tests/SwiftParserTest/ExpressionInterpretedAsVersionTupleTests.swift
Outdated
Show resolved
Hide resolved
StevenWong12
force-pushed
the
interpret_expr_syntax_as_version_tuple_syntax
branch
2 times, most recently
from
3172161 to
ce2f2f2
Compare
ahoppen
reviewed
Aug 30, 2023
StevenWong12
force-pushed
the
interpret_expr_syntax_as_version_tuple_syntax
branch
2 times, most recently
from
731504b to
b0e01fd
Compare
ahoppen
approved these changes
Aug 31, 2023
|
@swift-ci Please test |
ahoppen
force-pushed
the
interpret_expr_syntax_as_version_tuple_syntax
branch
from
b0e01fd to
490fe3d
Compare
…ression node To make it easier to interpret the version passed to `canImport(MyModule, _version: <#version#>)`, add `ExprSyntax.interpretedAsVersionTuple` that takes eg. `1.2.3`, which got parsed as a member access `3` to the `1.2` float literal and re-parses it as a `VersionTupleSyntax`. This relaxation also allows string literals as version parameters to `#if canImport`. Fixes swiftlang#1972 rdar://121070235 Co-Authored-By: Ziyang Huang <[email protected]>
ahoppen
force-pushed
the
interpret_expr_syntax_as_version_tuple_syntax
branch
from
490fe3d to
1382ffb
Compare
|
Picking this PR up. |
|
@swift-ci Please test |
rintaro
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1972