Skip to content

Add appendInterpolation with optional syntax nodes #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Matejkob
Copy link
Contributor

@Matejkob Matejkob commented Aug 20, 2023

This PR introduces a new method, appendInterpolation, to the SyntaxStringInterpolation struct, which takes an optional syntax node parameter. If the provided node is nil, no interpolation is added. Otherwise, interpolation is performed as usual.

Additionally, this new method has been integrated into the CodeGeneration package to eliminate the usage of interpolation.

Resolves part of #1977

@Matejkob Matejkob requested a review from ahoppen as a code owner August 20, 2023 20:11
Introduces a new method, appendInterpolation, to the SyntaxStringInterpolation struct, which takes an optional syntax node parameter. If the provided node is nil, no interpolation is added. Otherwise, interpolation is performed as usual.

Additionally, this new method has been integrated into the CodeGeneration package to eliminate the usage of interpolation.
@Matejkob Matejkob force-pushed the option-syntax-nodes-interpolation branch from b2e126f to 2c8a8c9 Compare August 20, 2023 20:12
@MaxDesiatov
Copy link
Contributor

@swift-ci test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏽

@ahoppen ahoppen merged commit e6700a2 into swiftlang:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants