build-script: always use the just-built swift compiler to build SwiftSyntax. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Syntax. Since we can now use SwiftPM from the build environment to build SwiftSyntax, we need to teach SwiftPM to always use the just-built swift compiler instead of the one from the environment. This ensures the binary compatibility of the SwiftSyntax dylib and the rest part of the stdlib.
|
@swift-ci please test |
rintaro
reviewed
Nov 2, 2018
| @@ -364,6 +364,8 @@ def main(): | |||
| sys.exit(1) | |||
|
|
|||
| try: | |||
| _environ = dict(os.environ) | |||
| os.environ['SWIFT_EXEC'] = args.swiftc_exec | |||
There was a problem hiding this comment.
Instead of mutating os.environ, you should use env= argument for subprocess.check_call().
There was a problem hiding this comment.
Good point! I'll make another PR.
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Improve method chaining, especially involving trailing closures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can now use SwiftPM from the build environment to build SwiftSyntax,
we need to teach SwiftPM to always use the just-built swift compiler instead
of the one from the environment. This ensures the binary compatibility of the
SwiftSyntax dylib and the rest part of the stdlib.