Skip to content

Fix Swift tools version in Readme #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chiragramani
Copy link
Contributor

@chiragramani chiragramani commented Apr 12, 2020

Changed the swift tools version to 5.2 since in the same manifest, Package.Dependency is initialised taking package name into account which is only available from swift 5.2 and the one used is marked as obsoleted.

@chiragramani chiragramani changed the title Fix Swift tools version in readme Fix Swift tools version in Readme Apr 12, 2020
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Looks good to me!

@ahoppen
Copy link
Member

ahoppen commented Apr 13, 2020

@swift-ci Please test

@chiragramani
Copy link
Contributor Author

chiragramani commented Apr 13, 2020

Thanks, @ahoppen ! I would also appreciate it if you can help in merging this pull request because I don't have write access to this repository.

@akyrtzi akyrtzi merged commit a03d511 into swiftlang:master Apr 13, 2020
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Remove trailing spaces from comments and keep spaces after block comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants