Delete grammar comments in CodeGeneration/SyntaxSupport and translated all other comments to documentation
#2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
kimdv
approved these changes
Sep 12, 2023
bnbarham
approved these changes
Sep 14, 2023
| @@ -1257,6 +1257,8 @@ public struct OriginallyDefinedInAttributeArgumentsSyntax: SyntaxProtocol, Synta | |||
|
|
|||
| // MARK: - PackElementExprSyntax | |||
|
|
|||
| /// A pack element expr spelled with `each`. | |||
There was a problem hiding this comment.
expression instead of expr? Same thing with repeat
…ted all other comments to documentation The grammar comments were partially out-of-date and weren’t very useful and all other comments should be documentation so that clients of swift-syntax can read them.
ahoppen
force-pushed
the
ahoppen/syntax-support-comments
branch
from
0ee366a to
79040ec
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Feb 12, 2024
A few cases that were missed by swiftlang#2179. rdar://113301253
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Feb 12, 2024
A few cases that were missed by swiftlang#2179. rdar://113301253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar comments were partially out-of-date and weren’t very useful and all other comments should be documentation so that clients of swift-syntax can read them.