Skip to content

Introduce do expressions #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2023
Merged

Introduce do expressions #2195

merged 4 commits into from
Oct 10, 2023

Conversation

hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Sep 14, 2023 •
edited
Loading

Allow do and do catch statements to be treated as expressions if they either have single expression branches, or have terminating then statements, following the same rules as if/switch expressions. This is currently gated behind an experimental feature flag pending evolution discussion.

@hamishknight hamishknight mentioned this pull request Sep 14, 2023
Merged
@hamishknight hamishknight force-pushed the do-it branch 10 times, most recently from f164c08 to 0c1ab96 Compare September 21, 2023 19:32
@hamishknight hamishknight changed the title [WIP] do expressions Introduce do expressions Sep 22, 2023
@hamishknight hamishknight marked this pull request as ready for review September 22, 2023 10:13
@hamishknight hamishknight force-pushed the do-it branch 7 times, most recently from 0366279 to 9716727 Compare September 28, 2023 20:42
@hamishknight hamishknight force-pushed the do-it branch 2 times, most recently from c5a1930 to c0376b4 Compare October 6, 2023 10:19
ahoppen
ahoppen reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of minor comments.

Also: Is there any plan to deprecate/remove DoStmtSyntax once do expressions have been accepted?

@hamishknight hamishknight force-pushed the do-it branch 2 times, most recently from 3971f55 to 00c45d0 Compare October 9, 2023 19:14
@hamishknight
Copy link
Contributor Author

Also: Is there any plan to deprecate/remove DoStmtSyntax once do expressions have been accepted?

Yeah that's the plan

@hamishknight
Copy link
Contributor Author

swiftlang/swift#68344

@swift-ci please test

@hamishknight hamishknight merged commit 1f3618d into swiftlang:main Oct 10, 2023
@hamishknight hamishknight deleted the do-it branch October 10, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishknight @ahoppen