-
Notifications
You must be signed in to change notification settings - Fork 440
[Macros] Introduce macro specification in assertMacroExpansion #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Macros] Introduce macro specification in assertMacroExpansion #2327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this issue @soumyamahunt!
773c715
to
49ab6cc
Compare
49ab6cc
to
8a5c581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏🏽 Looks very good. I just have a few comments on the documentation.
Also: Could you add an entry fro this in the 511.md release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution looks really nice, thank you!
Looks like this has a few merge conflicts now. Could you resolve them @soumyamahunt? |
f18828c
to
577366a
Compare
@ahoppen resolved conflicts |
@swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about squashing commits?
Looks like the documentation contains a few invalid references now. Could you resolve them by making sure that And squashing commits would also be appreciated. |
Head branch was pushed to by a user without write access
577366a
to
8001ce8
Compare
@ahoppen documentation links are fixed and commits squashed |
Allows testing extension and member macros conformances
8001ce8
to
b866edb
Compare
Thank you. There was a merge conflict in the release notes now. I took the liberty to fix it and force-push to your branch. |
@swift-ci Please test |
@swift-ci Please test Windows |
Resolves #2031.
Implements fixes suggested by @DougGregor.
Allows testing extension macros completely.