-
Notifications
You must be signed in to change notification settings - Fork 442
Change swift-format configuration to 120 columns #2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
bdd337d
to
0fda60d
Compare
@swift-ci Please test |
@swift-ci Please test Windows |
@@ -357,7 +365,8 @@ public let ATTRIBUTE_NODES: [Node] = [ | |||
kind: .differentiabilityArgument, | |||
base: .syntax, | |||
nameForDiagnostics: "differentiability argument", | |||
documentation: "A differentiability argument: either the \"self\" identifier, a function parameter name, or a function parameter index.", | |||
documentation: | |||
"A differentiability argument: either the \"self\" identifier, a function parameter name, or a function parameter index.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this change in general (I think 120 is a nice compromise between 80 and massive lines), though it really seems like we need to teach swift-format to split both strings and comments - the split here doesn't really make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't agree more. It would be amazing if swift-format
could split it in a better way 🥺
0fda60d
to
510ca34
Compare
@swift-ci Please test |
@swift-ci Please test Windows |
This makes the format the same as the one in sourcekit-lsp, converging towards a single format style. rdar://123241356
510ca34
to
4fae6c4
Compare
@swift-ci Please test |
@swift-ci Please test Windows |
This makes the format the same as the one in sourcekit-lsp, converging towards a single format style.
rdar://123241356