Add an accessor macro example #2565
Conversation
rockname
force-pushed
the
new-accessor-macro-example
branch
2 times, most recently
from
fd25603 to
295068d
Compare
rockname
force-pushed
the
new-accessor-macro-example
branch
from
295068d to
b7252d2
Compare
|
@swift-ci Please test |
|
|
||
| return [ | ||
| """ | ||
| get { self[\(raw: argument.expression)] } |
There was a problem hiding this comment.
I don’t think you need to use raw: here or in the setter.
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import SwiftUI |
There was a problem hiding this comment.
The example won’t compile on Linux and Windows if it depends on SwiftUI.
We’ve got two options here: Either wrap the macro in #if canImport(SwiftUI) or change it so it doesn’t depend on SwiftUI. Which one would you prefer?
There was a problem hiding this comment.
Thank you for proposing two options!
I'll choose the #if canImport(SwiftUI) option this time 🙏
| @@ -47,3 +47,7 @@ runMemberMacrosPlayground() | |||
| // MARK: - Peer Macros | |||
|
|
|||
| runPeerMacrosPlayground() | |||
|
|
|||
| // MARKL - Accessor Macros | |||
There was a problem hiding this comment.
| // MARKL - Accessor Macros | |
| // MARK: - Accessor Macros |
| private struct MyEnvironmentKey: EnvironmentKey { | ||
| static let defaultValue: String = "Default value" | ||
| } | ||
|
|
There was a problem hiding this comment.
Since the expansion of the macro is syntactic and doesn’t actually try to resolve MyEnvironmentKey, you could remove the declaration of MyEnvironmentKey.
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Issue: #2169
This PR introduces a new accessor macro example called
EnvironmentValueMacrothat automates the generation of getter / setter implementations for EnvironmentValues.private struct MyEnvironmentKey: EnvironmentKey { static let defaultValue: String = "Default value" } extension EnvironmentValues { + @EnvironmentValue(for: MyEnvironmentKey.self) + var myCustomValue: String - var myCustomValue: String { - get { self[MyEnvironmentKey.self] } - set { self[MyEnvironmentKey.self] = newValue } - } }