[6.0] Make swift-syntax build without warnings #2571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Mar 27, 2024
•
ahoppen
commented
- Explanation: swift-syntax currently emits warnings when building it. It should build free of warnings. Make a couple of adjustments to fix the warnings.
- Scope: Not really limited to a very specific area
- Risk: Moderate, affects multiple files but each change is pretty trivial.
- Testing: Verified that swift-syntax builds without warnings
- Issue: n/a
- Reviewer: @bnbarham on Make swift-syntax build without warnings #2558 and Fix two diagnostics when building swift-syntax using pre Swift-6 compilers #2569
|
@swift-ci Please test |
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 27, 2024
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
…ed version and deprecate a typealias This allows us to still use the underscored version internally (eg. when matching the syntax node kind during the creation of a `SyntaxEnum` and keep swift-syntax building without warnings.
In most other parts of the code base we only use the SPI attribute for Swift ≥5.8 compilers. If we unconditionally mark a keywords as SPI we run into issues if a syntax node (which is only experimental in Swift 5.8+) uses that keyword as a default value in its initializers. The concrete case here is the usage of `.dependsOn`.
We were relying on the `nonisolated(unsafe)` annotation of `Info.info` to make `Sendable` checking pass. But that feature is only available in Swift 6.0. To be able to build swift-syntax without warnings using Swift <6.0, we need to use `@unchecked Sendable` here.
ahoppen
force-pushed
the
ahoppen/6.0/fix-old-swift-diags
branch
from
956805e to
bfc2878
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.