Skip to content

[SwiftLexicalScopes][GSoC] Add simple scope queries and initial name lookup API structure #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 5, 2024
Merged
1 change: 1 addition & 0 deletions .spi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ builder:
- SwiftCompilerPlugin
- SwiftDiagnostics
- SwiftIDEUtils
- SwiftLexicalLookup
- SwiftOperators
- SwiftParser
- SwiftParserDiagnostics
Expand Down
13 changes: 13 additions & 0 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ let package = Package(
.library(name: "SwiftCompilerPlugin", targets: ["SwiftCompilerPlugin"]),
.library(name: "SwiftDiagnostics", targets: ["SwiftDiagnostics"]),
.library(name: "SwiftIDEUtils", targets: ["SwiftIDEUtils"]),
.library(name: "SwiftLexicalLookup", targets: ["SwiftLexicalLookup"]),
.library(name: "SwiftOperators", targets: ["SwiftOperators"]),
.library(name: "SwiftParser", targets: ["SwiftParser"]),
.library(name: "SwiftParserDiagnostics", targets: ["SwiftParserDiagnostics"]),
Expand Down Expand Up @@ -137,6 +138,18 @@ let package = Package(
dependencies: ["_SwiftSyntaxTestSupport", "SwiftIDEUtils", "SwiftParser", "SwiftSyntax"]
),

// MARK: SwiftLexicalLookup

.target(
name: "SwiftLexicalLookup",
dependencies: ["SwiftSyntax"]
),

.testTarget(
name: "SwiftLexicalLookupTest",
dependencies: ["_SwiftSyntaxTestSupport", "SwiftLexicalLookup"]
),

// MARK: SwiftLibraryPluginProvider

.target(
Expand Down
4 changes: 4 additions & 0 deletions Release Notes/601.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
- Description: Allows retrieving the represented literal value when valid.
- Issue: https://github.com/apple/swift-syntax/issues/405
- Pull Request: https://github.com/apple/swift-syntax/pull/2605

- `SyntaxProtocol` now has a method `ancestorOrSelf`.
- Description: Returns the node or the first ancestor that satisfies `condition`.
- Pull Request: https://github.com/swiftlang/swift-syntax/pull/2696

## API Behavior Changes

Expand Down
14 changes: 0 additions & 14 deletions Sources/SwiftBasicFormat/BasicFormat.swift
Original file line number Diff line number Diff line change
Expand Up @@ -676,17 +676,3 @@ fileprivate extension TokenSyntax {
}
}
}

fileprivate extension SyntaxProtocol {
/// Returns this node or the first ancestor that satisfies `condition`.
func ancestorOrSelf<T>(mapping map: (Syntax) -> T?) -> T? {
var walk: Syntax? = Syntax(self)
while let unwrappedParent = walk {
if let mapped = map(unwrappedParent) {
return mapped
}
walk = unwrappedParent.parent
}
return nil
}
}
213 changes: 213 additions & 0 deletions Sources/SwiftLexicalLookup/SimpleLookupQueries.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,213 @@
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2024 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//

import Foundation
import SwiftSyntax

extension SyntaxProtocol {
/// Returns all labeled statements available at a particular syntax node.
///
/// - Returns: Available labeled statements at a particular syntax node
/// in the exact order they appear in the source code, starting with the innermost statement.
///
/// Example usage:
/// ```swift
/// one: while cond1 {
/// func foo() {
/// two: while cond2 {
/// three: while cond3 {
/// break // 1
/// }
/// break // 2
/// }
/// }
/// break // 3
/// }
/// ```
/// When calling this function at the first `break`, it returns `three` and `two` in this exact order.
/// For the second `break`, it returns only `two`.
/// The results don't include `one`, which is unavailable at both locations due to the encapsulating function body.
/// For `break` numbered 3, the result is `one`, as it's outside the function body and within the labeled statement.
/// The function returns an empty array when there are no available labeled statements.
@_spi(Experimental) public func lookupLabeledStmts() -> [LabeledStmtSyntax] {
collectNodesOfTypeUpToFunctionBoundary(LabeledStmtSyntax.self)
}

/// Returns the catch node responsible for handling an error thrown at a particular syntax node.
///
/// - Returns: The catch node responsible for handling an error thrown at the lookup source node.
/// This could be a `do` statement, `try?`, `try!`, `init`, `deinit`, accessors, closures, or function declarations.
///
/// Example usage:
/// ```swift
/// func x() {
/// do {
/// try foo()
/// try? bar()
/// } catch {
/// throw error
/// }
/// }
/// ```
/// When calling this function on `foo`, it returns the `do` statement.
/// Calling the function on `bar` results in `try?`.
/// When used on `error`, the function returns the function declaration `x`.
/// The function returns `nil` when there's no available catch node.
@_spi(Experimental) public func lookupCatchNode() -> Syntax? {
lookupCatchNodeHelper(traversedCatchClause: false)
}

// MARK: - lookupCatchNode

/// Given syntax node location, finds where an error could be caught. If `traverseCatchClause` is set to `true` lookup will skip the next do statement.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, 120 columns

private func lookupCatchNodeHelper(traversedCatchClause: Bool) -> Syntax? {
guard let parent else { return nil }

switch parent.as(SyntaxEnum.self) {
case .doStmt:
if traversedCatchClause {
return parent.lookupCatchNodeHelper(traversedCatchClause: false)
} else {
return parent
}
case .catchClause:
return parent.lookupCatchNodeHelper(traversedCatchClause: true)
case .tryExpr(let tryExpr):
if tryExpr.questionOrExclamationMark != nil {
return parent
} else {
return parent.lookupCatchNodeHelper(traversedCatchClause: traversedCatchClause)
}
case .functionDecl, .accessorDecl, .initializerDecl, .deinitializerDecl, .closureExpr:
return parent
case .exprList(let exprList):
if let tryExpr = exprList.first?.as(TryExprSyntax.self), tryExpr.questionOrExclamationMark != nil {
return Syntax(tryExpr)
}
return parent.lookupCatchNodeHelper(traversedCatchClause: traversedCatchClause)
default:
return parent.lookupCatchNodeHelper(traversedCatchClause: traversedCatchClause)
}
}

// MARK: - walkParentTree helper methods

/// Returns the innermost node of the specified type up to a function boundary.
fileprivate func innermostNodeOfTypeUpToFunctionBoundary<T: SyntaxProtocol>(
_ type: T.Type
) -> T? {
collectNodesOfTypeUpToFunctionBoundary(type, stopWithFirstMatch: true).first
}

/// Collect syntax nodes matching the collection type up until encountering one of the specified syntax nodes. The nodes in the array are inside out, with the innermost node being the first.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also wrap this comment at 120 columns?

fileprivate func collectNodesOfTypeUpToFunctionBoundary<T: SyntaxProtocol>(
_ type: T.Type,
stopWithFirstMatch: Bool = false
) -> [T] {
collectNodes(
ofType: type,
upTo: [
MemberBlockSyntax.self,
FunctionDeclSyntax.self,
InitializerDeclSyntax.self,
DeinitializerDeclSyntax.self,
AccessorDeclSyntax.self,
ClosureExprSyntax.self,
SubscriptDeclSyntax.self,
],
stopWithFirstMatch: stopWithFirstMatch
)
}

/// Callect syntax nodes matching the collection type up until encountering one of the specified syntax nodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Callect syntax nodes matching the collection type up until encountering one of the specified syntax nodes.
/// Collect syntax nodes matching the collection type up until encountering one of the specified syntax nodes.

private func collectNodes<T: SyntaxProtocol>(
ofType type: T.Type,
upTo stopAt: [SyntaxProtocol.Type],
stopWithFirstMatch: Bool = false
) -> [T] {
var matches: [T] = []
var nextSyntax: Syntax? = Syntax(self)
while let currentSyntax = nextSyntax {
if stopAt.contains(where: { currentSyntax.is($0) }) {
break
}

if let matchedSyntax = currentSyntax.as(T.self) {
matches.append(matchedSyntax)
if stopWithFirstMatch {
break
}
}

nextSyntax = currentSyntax.parent
}

return matches
}
}

extension FallThroughStmtSyntax {
/// Returns the source and destination of a `fallthrough`.
///
/// - Returns: `source` as the switch case that encapsulates the `fallthrough` keyword and
/// `destination` as the switch case that the `fallthrough` directs to.
///
/// Example usage:
/// ```swift
/// switch value {
/// case 2:
/// doSomething()
/// fallthrough
/// case 1:
/// doSomethingElse()
/// default:
/// break
/// }
/// ```
/// When calling this function at the `fallthrough`, it returns `case 2` and `case 1` in this exact order.
/// The `nil` results handle ill-formed code: there's no `source` if the `fallthrough` is outside of a case.
/// There's no `destination` if there is no case or `default` after the source case.
@_spi(Experimental) public func lookupFallthroughSourceAndDestintation()
-> (source: SwitchCaseSyntax?, destination: SwitchCaseSyntax?)
{
guard
let originalSwitchCase = innermostNodeOfTypeUpToFunctionBoundary(
SwitchCaseSyntax.self
)
else {
return (nil, nil)
}

let nextSwitchCase = lookupNextSwitchCase(at: originalSwitchCase)

return (originalSwitchCase, nextSwitchCase)
}

/// Given a switch case, returns the case that follows according to the parent.
private func lookupNextSwitchCase(at switchCaseSyntax: SwitchCaseSyntax) -> SwitchCaseSyntax? {
guard let switchCaseListSyntax = switchCaseSyntax.parent?.as(SwitchCaseListSyntax.self) else { return nil }

var visitedOriginalCase = false

for child in switchCaseListSyntax.children(viewMode: .sourceAccurate) {
if let thisCase = child.as(SwitchCaseSyntax.self) {
if thisCase.id == switchCaseSyntax.id {
visitedOriginalCase = true
} else if visitedOriginalCase {
return thisCase
}
}
}

return nil
}
}
12 changes: 0 additions & 12 deletions Sources/SwiftParserDiagnostics/SyntaxExtensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -119,18 +119,6 @@ extension SyntaxProtocol {
}
}

/// Returns this node or the first ancestor that satisfies `condition`.
func ancestorOrSelf<T>(mapping map: (Syntax) -> T?) -> T? {
var walk: Syntax? = Syntax(self)
while let unwrappedParent = walk {
if let mapped = map(unwrappedParent) {
return mapped
}
walk = unwrappedParent.parent
}
return nil
}

/// Returns `true` if the next token's leading trivia should be made leading trivia
/// of this mode, when it is switched from being missing to present.
var shouldBeInsertedAfterNextTokenTrivia: Bool {
Expand Down
14 changes: 13 additions & 1 deletion Sources/SwiftSyntax/SyntaxProtocol.swift
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ extension SyntaxProtocol {
}
}

// MARK: Children / parent
// MARK: Children / parent / ancestor

extension SyntaxProtocol {
/// A sequence over the children of this node.
Expand Down Expand Up @@ -238,6 +238,18 @@ extension SyntaxProtocol {
public var previousToken: TokenSyntax? {
return self.previousToken(viewMode: .sourceAccurate)
}

/// Returns this node or the first ancestor that satisfies `condition`.
public func ancestorOrSelf<T>(mapping map: (Syntax) -> T?) -> T? {
var walk: Syntax? = Syntax(self)
while let unwrappedParent = walk {
if let mapped = map(unwrappedParent) {
return mapped
}
walk = unwrappedParent.parent
}
return nil
}
}

// MARK: Accessing tokens
Expand Down
Loading