[6.2][SwiftParser] Implement nonisolated(nonsending) specifier
#3055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
keith,
DougGregor,
ahoppen and
bnbarham
as code owners
…ng` argument This is part of SE-0461 proposal where `nonisolated` has to be marked as `nonsending` in type context to indicate that the function type it's attached to is caller isolated.
…suming '('
It's possible that `(nonsending)` was omitted and instead we are
at the parameter list of a function type. Checking ahead allows
for a better diagnostics and recovery.
…s with arguments
…odifiers while skipping Otherwise in situations like `nonisolated()` `canParseType` would return `true` because `()` is valid type.
…ing` in expression context
xedin
force-pushed
the
nonisolated-nonsending-attr-6.2
branch
from
01a3b8f to
a4a4159
Compare
|
swiftlang/swift#80807 |
bnbarham
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
This is part of SE-0461 proposal where
nonisolatedhas to bemarked as
nonsendingin type context to indicate that thefunction type it's attached to is caller isolated.
Main Branch PR: [SwiftParser] Implement
nonisolated(nonsending)specifier #3047Risk: Low (The only risk here is related to
nonisolatedkeyword expansion to acceptnonsendingmodifier, this could cause a source break if there exists a function which such a name an an argument with namenonsending, which seems like a very low probability).Reviewed By: @hamishknight @ahoppen @bnbarham
Testing: Added new tests to the test suite.