Add docCommentValue property to Trivia#3230
Conversation
|
If I understand it correctly, this PR is based on top of #2966, right? Thanks for picking that stale PR up! To make sure we give @zyadtaha credit where credit is due for all the work he put into the original PR, would you mind basing you changes on top of his branch so that we retain his original commit and keep him listed as that commit’s author? The author field should be retained if you cherry-pick a commit or rebase it (feel free to read up on the distinction between committer and author in git if you are interested 😉). A real review will follow, I think it might be easier to get the git logistics sorted out first though. |
141f90b to
6620e42
Compare
|
@ahoppen I think this should be good now |
6620e42 to
bdce4c4
Compare
ahoppen
left a comment
There was a problem hiding this comment.
Thanks for picking the PR up again, @PhantomInTheWire
- Fix blank line stripping to only remove first/last line, not all blank lines - Add regression test and convert test strings to multi-line format - Move release notes entry from 602 to 604
e0845a3 to
6b895e1
Compare
ahoppen
left a comment
There was a problem hiding this comment.
Just two style comments, otherwise LGTM.
Signed-off-by: Karan <[email protected]>
|
@swift-ci please test |
|
@swift-ci test macos |
|
@swift-ci test linux |
ahoppen
left a comment
There was a problem hiding this comment.
LGTM. I forgot a little bit that this is swift-syntax and we haven an RFC process for adding/changing public API. Could you create a forum post as described in there to allow others to weigh in? Once that’s done, we can hit merge. Any potential feedback can be addressed in follow-up PRs.
|
@swift-ci please test macos |
fixes: #1890