Allow passing type information to ConvertStoredPropertyToComputed #3249
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padmashree06
requested review from
ahoppen,
hamishknight,
hborla and
rintaro
as code owners
ahoppen
reviewed
Jan 29, 2026
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thanks. This looks good. Could you add two test cases? One where a type annotation is missing and one is provided and one where it is not?
Author
|
Thank you for reviewing. I will add the tests. |
Author
|
I have added tests. Please review. |
ahoppen
approved these changes
Jan 31, 2026
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Looks good. I just realized that we don’t have this refactoring included in SyntaxCodeAction.swift in SourceKit-LSP. Would you like to add it to that list as well? You should be able to use the cursorInfo request to determine the type of a variable there.
Member
|
@swift-ci Please test |
Member
|
Can you please ensure that your tests pass? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
ConvertStoredPropertyToComputedto accept a TypeSyntax via a new Context struct. This allows refactoring to include type annotations when converting stored properties to computed properties.Resolves: swiftlang/sourcekit-lsp#2459