Skip to content

Update the README to include macOS trigger for Swift CI #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal shahmishal requested a review from ahoppen September 12, 2018 07:02
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Is Linux PR testing also coming?

@shahmishal
Copy link
Member Author

Can we build/test swift-syntax on Linux?

@ahoppen
Copy link
Member

ahoppen commented Sep 12, 2018

As of #5 SwiftSyntax should build on Linux. I'd be great if we had PR testing for Linux, in which case we could validate that all tests pass on Linux CI from that PR. Afterwards we should probably also enable testing on the Linux bots.

@shahmishal
Copy link
Member Author

@ahoppen Sounds good, I will add the support for Linux PR testing tomorrow.

@nkcsgexi
Copy link
Contributor

Wow, this is amazing! Thank you for making it happen @shahmishal !

@nkcsgexi
Copy link
Contributor

@swift-ci Please test macOS platform

@nkcsgexi nkcsgexi merged commit 0693b54 into master Sep 12, 2018
@keith keith deleted the shahmishal-patch-1 branch December 7, 2022 00:53
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Ensure line breaks between type members wrapped in an `#if` block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants