Fix crash when loading test content records from the type metadata section. #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction. Looks like # caused a regression: the compiler appears to be dead-code-stripping the classes we emit to contain test content records. This PR changes the design back to using a protocol so that the members we need are always covered by `@_alwaysEmitConformanceMetadata`. This makes `_TestDiscovery` a little harder to use with legacy lookup, but it's all experimental and eventually going to be removed anyway. Resolves rdar://146809312.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
Windows CI is down right now. Self-reviewing due to potential impact on the toolchain. |
grynspan
commented
Mar 12, 2025
| protocol TestContentRecordContainer: _TestDiscovery.TestContentRecordContainer {} | ||
|
|
||
| /// An abstract base class describing a type that contains tests. | ||
| /// A protocol base class describing a type that contains tests. |
There was a problem hiding this comment.
Typo here fixed on main already.
grynspan
commented
Mar 12, 2025
| protocol TestContentRecordContainer: _TestDiscovery.TestContentRecordContainer {} | ||
|
|
||
| /// An abstract base class describing a type that contains tests. | ||
| /// A protocol base class describing a type that contains tests. | ||
| /// | ||
| /// - Warning: This class is used to implement the `@Test` macro. Do not use it |
There was a problem hiding this comment.
Typo here fixed on main already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #880 and/or #1010 caused a regression: the compiler appears to be dead-code-stripping the classes we emit to contain test content records. This PR changes the design back to using a protocol so that the members we need are always covered by
@_alwaysEmitConformanceMetadata. This makes_TestDiscoverya little harder to use with legacy lookup, but it's all experimental and eventually going to be removed anyway.Resolves rdar://146809312.
Checklist: