Skip to content

🍒6.1: [CMake] Set CMP0157 to OLD when targeting Android with the Windows toolchain (#1009) #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2025
Merged

🍒6.1: [CMake] Set CMP0157 to OLD when targeting Android with the Windows toolchain (#1009) #1045

merged 1 commit into from
Mar 30, 2025

Conversation

etcwilde
Copy link
Contributor

The C++ Swift Driver on Windows doesn't emit objects in the same place as the Swift Swift Driver when building for Android resulting in build failures about missing object files.

<unknown>:0: error: no such file or directory: 'Sources/Testing/CMakeFiles/Testing.dir/ABI/EntryPoints/ABIEntryPoint.swift.o'
<unknown>:0: error: no such file or directory: 'Sources/Testing/CMakeFiles/Testing.dir/ABI/EntryPoints/EntryPoint.swift.o'
<unknown>:0: error: no such file or directory: 'Sources/Testing/CMakeFiles/Testing.dir/ABI/EntryPoints/SwiftPMEntryPoint.swift.o'
...

Cherry-picking #1009 to unblock the 6.1 release: https://ci-external.swift.org/job/swift-6.1-windows-toolchain/164/

(cherry picked from commit a5dfbc2)

@weliveindetail @etcwilde
[CMake] Set CMP0157 to OLD when targeting Android with the Windows to…
00df135 
…olchain (swiftlang#1009)

There is no early swift-driver build for the Windows toolchain. As a
result, swift-testing fails to build properly when CMP0157 is set to NEW
due to object files not being generated.

This sets CMP0157 to OLD when targeting Android with the Windows
toolchain until the early swift-driver is available on Windows. This is
analog to
swiftlang/swift-corelibs-foundation#5180

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.

(cherry picked from commit a5dfbc2)
@etcwilde etcwilde added windows 🪟 Windows support build 🧱 Affects the project's build configuration or process labels Mar 30, 2025
@etcwilde etcwilde requested a review from shahmishal March 30, 2025 23:10
@shahmishal
Copy link
Member

@swift-ci test

@shahmishal shahmishal merged commit 94083ba into swiftlang:release/6.1 Mar 30, 2025
3 checks passed
@grynspan grynspan added this to the Swift 6.1 milestone Mar 31, 2025
@grynspan grynspan added bug 🪲 Something isn't working android 🤖 Android support labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briancroom briancroom briancroom approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann dennisweissmann is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@etcwilde etcwilde

Labels
android 🤖 Android support bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process windows 🪟 Windows support
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@etcwilde @shahmishal @briancroom @grynspan @weliveindetail