Draft
Conversation
grynspan
added
enhancement
This PR replaces our use of `objc_addLoadImageFunc()` with calls to `objc_copyImageNames()`, `dlopen()`, and `_dyld_get_dlopen_image_header()`. This is a bit less efficient, but it avoids the problem of deadlocking if we happen to touch Swift API/internals that need to acquire the lock that libobjc is holding during `objc_addLoadImageFunc()`'s callback. Resolves rdar://169186671.
grynspan
force-pushed
the
jgrynspan/169186671-replace-objc_addLoadImageFunc
branch
from
3e036bc to
9b5ebb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces our use of
objc_addLoadImageFunc()with calls toobjc_copyImageNames(),dlopen(), and_dyld_get_dlopen_image_header(). This is a bit less efficient, but it avoids the problem of deadlocking if we happen to touch Swift API/internals that need to acquire the lock that libobjc is holding duringobjc_addLoadImageFunc()'s callback.Resolves rdar://169186671.
Checklist: