Add a mode flags optionset to FileHandle.#1597
Merged
Conversation
This PR adds an `OptionSet`-conforming type to `FileHandle` so that we don't have to hard-code mode strings we pass to `fopen()`.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
grynspan
commented
Feb 27, 2026
| // Note "x" in the mode string which indicates that the file should be | ||
| // created and opened exclusively. The underlying `fopen()` call will thus | ||
| // fail with `EEXIST` if a file exists at `filePath`. | ||
| let file = try FileHandle(atPath: filePath, mode: "wxeb") |
Contributor
Author
There was a problem hiding this comment.
"e" (O_CLOEXEC) is implied by default with the new optionset; you have to request inheritance explicitly instead (which we don't ever do currently).
stmontgomery
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
OptionSet-conforming type toFileHandleso that we don't have to hard-code mode strings we pass tofopen().Checklist: